Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-compose): Make worker use correct healthcheck (#23455) #23587

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

Since Celery 5.0 the global options (-A, --app) can no longer be positioned after the sub-command. Instead, they must be positioned as an option for the celery command. This PR correctly positions the global option for the celery-healthcheck in docker-compose.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

CONTAINER ID   IMAGE                                COMMAND                     STATUS                         PORTS           NAMES                                                                 
58252b3d19e5   apache/superset:latest-dev           "/app/docker/docker-…"      Up About an hour (unhealthy)   8088/tcp        superset_worker

After:

CONTAINER ID   IMAGE                                COMMAND                     STATUS                       PORTS           NAMES                                                                 
a02f26ae8921   apache/superset:latest-dev           "/app/docker/docker-…"      Up About an hour (healthy)   8088/tcp        superset_worker

TESTING INSTRUCTIONS

docker-compose up

ADDITIONAL INFORMATION

  • Has associated issue: fixes Unhealthy worker in Portainer #23042 and Fix for worker healthcheck #23455
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the link to the docs in the description! ❤️

@rusackas rusackas merged commit 8f4ed70 into apache:master Apr 5, 2023
@sebastianliebscher sebastianliebscher deleted the fix-worker-unhealthy branch April 5, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhealthy worker in Portainer
3 participants