-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support further drill by in the modal #23615
Conversation
useEffect(() => { | ||
setChartDataResult(undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
74b4254
to
8fc8b58
Compare
Codecov Report
@@ Coverage Diff @@
## master #23615 +/- ##
==========================================
+ Coverage 67.94% 68.02% +0.07%
==========================================
Files 1918 1919 +1
Lines 73890 73929 +39
Branches 8058 8066 +8
==========================================
+ Hits 50204 50288 +84
+ Misses 21625 21574 -51
- Partials 2061 2067 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1e0d6fd
to
82013ed
Compare
SUMMARY
Before, user could only drill by once, from the original chart. This PR implements further drilling in the drill by modal. In drill by modal, only drill by action is available - drill to detail and cross filtering is not available.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-04-07.at.13.33.08.mov
TESTING INSTRUCTIONS
DRILL_BY
ffADDITIONAL INFORMATION