-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump wtforms and add missing flask-limiter #23680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23680 +/- ##
==========================================
+ Coverage 66.25% 67.98% +1.73%
==========================================
Files 1937 1937
Lines 74933 74929 -4
Branches 8137 8137
==========================================
+ Hits 49645 50941 +1296
+ Misses 23203 21903 -1300
Partials 2085 2085
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 99 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new clean _func
prefixed params
Commit contains updates to base.txt which need to be merged once latest commit is pulled. Once incoming are an accepted build fails on pygments conflicts (it tries to install pygments==2.15.0 & pygments==2.12.0). |
SUMMARY
Bumps wtforms to the latest and adapt code to breaking changes. Also adds flask-limiter and it's dependencies since it's a new base requirement on flask-appbuilder
More details on the linked issue
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION