-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove RemovedInMarshmallow4 warnings #23704
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23704 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 1922 1922
Lines 74103 74103
Branches 8101 8101
=======================================
Hits 50480 50480
Misses 21545 21545
Partials 2078 2078
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all the hard work here, this will really help when we upgrade to Marshmallow 4 👍
This reverts commit b31efba.
This reverts commit b31efba.
SUMMARY
Since marshmallow 3.10 passing field metadata via keyword arguments is deprecated. Since marshmallow 3.13 the use of
missing / default
is deprecated. This generates a lot of warnings during testing and prevents future upgrades to marshmallow >4.This PR makes changes accordingly.
TESTING INSTRUCTIONS
pytest
or./scripts/tests/run.sh