Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api v1): Deprecate superset/override_role_permissions endpoint #23714

Merged
merged 1 commit into from
Apr 18, 2023
Merged

chore(api v1): Deprecate superset/override_role_permissions endpoint #23714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion superset/security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods
}

ADMIN_ONLY_PERMISSIONS = {
"can_override_role_permissions",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only removing since I noticed it was duplicated a couple lines below

"can_sync_druid_source",
"can_override_role_permissions",
"can_approve",
Expand Down
1 change: 1 addition & 0 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ def datasources(self) -> FlaskResponse:
@has_access_api
@event_logger.log_this
@expose("/override_role_permissions/", methods=["POST"])
@deprecated()
def override_role_permissions(self) -> FlaskResponse:
"""Updates the role with the give datasource permissions.

Expand Down