Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filters): Stop breaking if translateToSql returns an object #23715

Merged
merged 3 commits into from
May 8, 2023
Merged

fix(filters): Stop breaking if translateToSql returns an object #23715

merged 3 commits into from
May 8, 2023

Commits on May 8, 2023

  1. Filters: 

    - Consider cases where translateToSql doesn't return a string when getting the default label of a filter
- Add tests for changes
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed May 8, 2023
    Configuration menu
    Copy the full SHA
    1bed57e View commit details
    Browse the repository at this point in the history

  2. Filters: 

    - Moving logic to extract colum_name to getSimpleSQLExpression instead
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed May 8, 2023
    Configuration menu
    Copy the full SHA
    699870a View commit details
    Browse the repository at this point in the history

  3. Filters: 

    - Optional chaining when accessing column_name
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed May 8, 2023
    Configuration menu
    Copy the full SHA
    41c4a07 View commit details
    Browse the repository at this point in the history