feat(sqllab): add headers when copying results to clipboard #23720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When copying SQL Lab results from the query history to the clipboard, the headers are not included in the payload. This PR adds the headers. While updating the tests I noticed that we were missing test cases for what the
columns
array actually looks like; it's usuallycolumns: { name: string }[]
, notcolumns: string[]
. I therefore updated one of the tests to use the object-basedcolumns
array instead of the string-based one.AFTER
Now when you copy this:
You get this (the headers may appear to be off, but it's because they're tab separated, which isn't appropriately reflected in the code block):
BEFORE
Previously you got this:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION