fix: get or create db with an existing invalid URL

[dpgaspar]

SUMMARY

When an existing invalid URL on the examples database exists, updating or reseting the examples database connection fails with:

121, in make_url_safe
    raise DatabaseInvalidError()  # pylint: disable=raise-missing-from
superset.databases.commands.exceptions.DatabaseInvalidError: Database parameters are invalid.

With this fix the get_or_create_db can support the existing invalid URI and update it URI with a new valid URI

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23737 (a6e9791) into master (44557f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a6e9791 differs from pull request most recent head 61f126d. Consider uploading reports for the commit 61f126d to get more accurate results

@@           Coverage Diff           @@
##           master   #23737   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        1922     1922           
  Lines       74102    74103    +1     
  Branches     8100     8100           
=======================================
+ Hits        50474    50476    +2     
+ Misses      21550    21549    -1     
  Partials     2078     2078           

Flag	Coverage Δ
hive	53.25% <75.00%> (+0.05%)	⬆️
mysql	79.24% <100.00%> (+0.01%)	⬆️
postgres	79.31% <100.00%> (+<0.01%)	⬆️
presto	53.17% <75.00%> (+0.05%)	⬆️
python	83.16% <100.00%> (+<0.01%)	⬆️
sqlite	77.81% <100.00%> (+0.01%)	⬆️
unit	53.05% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/common/query_context_processor.py	89.38% <100.00%> (+0.81%)	⬆️
superset/models/core.py	90.16% <100.00%> (+0.43%)	⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

LGTM

[villebro]

I almost asked about why the old exceptions here aren't valid any more. To answer that question for other potential reviewers: we're already reraising all exceptions to DatabaseInvalidError here:

superset/superset/databases/utils.py

Lines 120 to 121 in 44557f5

	except Exception:
	raise DatabaseInvalidError() # pylint: disable=raise-missing-from