-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrates Dual Line Chart to Mixed Chart #23910
feat: Migrates Dual Line Chart to Mixed Chart #23910
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23910 +/- ##
==========================================
+ Coverage 57.42% 57.46% +0.03%
==========================================
Files 1951 1951
Lines 75438 75394 -44
Branches 8218 8218
==========================================
+ Hits 43320 43322 +2
+ Misses 30007 29961 -46
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c6be132
to
e0167c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving Cypress code changes... looking good, thank you for tackling all this!!
e0167c6
to
fd0e426
Compare
fb3c478
to
7373a6d
Compare
7373a6d
to
3fd5ac2
Compare
SUMMARY
This PR migrates the Dual Line Chart to Mixed Chart (ECharts).
AFTER SCREENSHOTS
TESTING INSTRUCTIONS
1 - Make sure all Dual Line charts were converted to Mixed charts
2 - Make sure Dual Line is not available anymore in the viz picker
3 - Make sure that it's possible to revert the migration by executing superset db downgrade and reverting this PR
ADDITIONAL INFORMATION
1 - Make sure all Treemap (legacy) charts were converted to Treemap
2 - Make sure Treemap (legacy) is not available anymore in the viz picker
3 - Make sure that it's possible to revert the migration by executing superset db downgrade and reverting this PR