Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): condition formatting can't formate 0 values #24008

Merged

Conversation

Always-prog
Copy link
Contributor

SUMMARY

Conditional formatting was not working for cells with value 0. This PR fixes the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

image

After

image

TESTING INSTRUCTIONS

  1. Create a table chart.
  2. Create a metric from SQL (0).
  3. Add a condition for the metric.
  4. The don't condition works for cells with value 0.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #24008 (7a668fa) into master (7757b61) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 7a668fa differs from pull request most recent head 1741041. Consider uploading reports for the commit 1741041 to get more accurate results

@@            Coverage Diff             @@
##           master   #24008      +/-   ##
==========================================
- Coverage   68.19%   68.13%   -0.06%     
==========================================
  Files        1941     1941              
  Lines       75277    75304      +27     
  Branches     8166     8166              
==========================================
- Hits        51333    51308      -25     
- Misses      21855    21907      +52     
  Partials     2089     2089              
Flag Coverage Δ
hive ?
javascript 54.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/plugins/plugin-chart-table/src/TableChart.tsx 44.91% <100.00%> (ø)
superset/views/core.py 75.38% <100.00%> (+0.25%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

Closing and re-opening in order to kick-start CI.

@rusackas rusackas closed this Aug 23, 2023
@rusackas rusackas reopened this Aug 23, 2023
@Always-prog
Copy link
Contributor Author

Thanks for taking a look, @rusackas! It seems that all CI tests have passed.

@rusackas rusackas merged commit 0d5be8e into apache:master Aug 24, 2023
28 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 24, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 24, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants