chore: remove user registrations menu for non-admins #24198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently only Admins have "menu access on Security", but despite that, non-admins have "menu access on User's Statistics" and "menu access on "User Registrations" which belong under the "Security" menu. This removes menu access, as they aren't really able to access the menu. We also bump FAB to the lastest version, which includes a fix to the "User Registrations" view registration: dpgaspar/Flask-AppBuilder#2051
AFTER
After the change, a Gamma user with Alerts & Reports and RLS access will only see the RLS menu under Security:
BEFORE
Previously, they would also see the User Registrations menu:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION