-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allows new values for single value filters #24388
feat: Allows new values for single value filters #24388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24388 +/- ##
==========================================
- Coverage 69.05% 68.96% -0.09%
==========================================
Files 1903 1904 +1
Lines 74530 74095 -435
Branches 8105 8121 +16
==========================================
- Hits 51464 51101 -363
+ Misses 20955 20881 -74
- Partials 2111 2113 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit dc042c6)
SUMMARY
Allows new values for single value filters. This feature already exists for multiple value filters.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-06-13.at.10.56.06.mov
TESTING INSTRUCTIONS
Check that single value native filters allow free form text.
ADDITIONAL INFORMATION