Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Restyle documentation landing page and community page #24393

Merged
merged 92 commits into from
Jun 15, 2023

Conversation

thiagorossener
Copy link
Contributor

@thiagorossener thiagorossener commented Jun 13, 2023

SUMMARY

Restyles documentation landing page and community page, and adds some functionalities like a community calendar for Superset events and a newsletter section.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Old Home Page

old-landing-page

New Home Page

new-landing-page

Old Community Page

old-community-page

New Community Page

new-community-page

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@thiagorossener thiagorossener marked this pull request as ready for review June 13, 2023 19:31
<List.Item className="item">
<List.Item.Meta
avatar={
<a className="title" href={url} target="_blank">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add link titles for accessibility. I haven't scanned through, but there may be many other places we could improve accessibility with aria labels and such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just added some aria labels where it made sense.

.description {
font-size: 14px;
line-height: 20px;
color: #5f5f5f;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of hard-coded colors... since we're using Emotion, we might want to provide a theme for any reusable values (type styles, colors, spacings, etc)

display: none;
--ifm-font-family-base: Roboto;
--ifm-footer-background-color: #173036;
--ifm-footer-color: #87939a;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment elsewhere about using Emotion theming, but this works too ¯\_(ツ)_/¯

Maybe it's worth pulling out the other static colors into this var list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I refactored the colors to use the vars from the list :)

@rusackas
Copy link
Member

I can't push to this fork/branch, but the 6 new SVG files need newlines at the ends to pass linting. You can run pre-commit run --all-files from the root directory to take care of that automatically.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, and a tip on some linting issues, but in general this looks good to me, and the site looks SOOOOO much better.

@rusackas
Copy link
Member

rusackas commented Jun 14, 2023

Mobile screenshot, in case anyone else is wondering about responsiveness:

@mistercrunch
Copy link
Member

LOOKS AMAZING!

@rusackas rusackas merged commit 892de8a into apache:master Jun 15, 2023
@thiagorossener thiagorossener deleted the preset/new-docs-design branch June 21, 2023 14:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants