docker (build) without DOCKER_BUILDKIT #24507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to #24504 if you remove DOCKER_BUILDKIT=1 then this should not affect the build process
alekseyolg
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
|
Can you also remove unnecessary |
|
@sebastianliebscher I tried creating a test pull request with your suggestion, but it failed on build https://github.com/apache/superset/actions/runs/5365790263/jobs/9734827799?pr=24507 Apparently, this option is still necessary for the build (but if you believe your links, everything should work successfully). If you have no idea why this is happening, then I suggest closing this pull request. |
|
Since this idea was not working - I close it. |
|
Since this idea was not working - I close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #24504 if you remove DOCKER_BUILDKIT=1 then this should not affect the build process
TESTING INSTRUCTIONS
Manually build from the Dockerfile,
docker build -t superset
And the build should finish without error.
Successfully tagged superset:latest