Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): dashboard requests to database equal the number of slices it has #24709

Merged
merged 6 commits into from
Oct 20, 2023
Merged

fix(chore): dashboard requests to database equal the number of slices it has #24709

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e567ad
fix(chore): dashboard requests to database equal the number of slices…
Always-prog Jul 16, 2023
ba140a7
ooops
Always-prog Jul 16, 2023
3e7b9bf
fix(chore): simplify getting dashboard in get_by_id_or_slug
Always-prog Jul 16, 2023
d1f8af9
removed unused
Always-prog Jul 16, 2023
7068e10
fix(chore): return back base filter in dashboard get_by_id_or_slug & …
Always-prog Jul 16, 2023
219310e
pylint
Always-prog Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions superset/daos/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ def get_by_id_or_slug(cls, id_or_slug: int | str) -> Dashboard:
query = (
db.session.query(Dashboard)
.filter(id_or_slug_filter(id_or_slug))
.outerjoin(Slice, Dashboard.slices)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpgaspar would you mind looking into this as it seems you added this logic in #22358? Note it's interesting that the unit/integration tests passed with the removal of these two lines.

.outerjoin(Slice.table)
.outerjoin(Dashboard.owners)
.outerjoin(Dashboard.roles)
)
Expand Down