-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update AWS Athena and Redshift docs #24751
Conversation
Paging @cbuffevant for a review (via the Database Familiarity Rolodex - sign on up, everyone!) |
cc @sfirke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM the Readshift part. I tried them out in our cluster.
redshift.mdx is failing the linter because of spaces at the ends of lines. If you can clean that up by hand or by running |
Thanks for fixing the PR title and attempting to fix the lint issues @rusackas :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't speak to the substance of the changes - they look like a nice addition! - but left a few small suggestions where there was a missing word or sentence that didn't read smoothly.
thanks @sfirke for the review. I have addressed your comments. |
SUMMARY
update AWS Athena and Redshift docs
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION