Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dao): Remove redundant convenience methods #24967

Merged
merged 1 commit into from
Aug 14, 2023
Merged

chore(dao): Remove redundant convenience methods #24967

merged 1 commit into from
Aug 14, 2023

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Aug 11, 2023 •
edited
Loading

SUMMARY

The DatasetDAO has a a number of convenience methods which either weren't called, or likely should be called by the corresponding DAO which maps to the associated command (unless people feel strongly otherwise).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-92] Proposal for restructuring the Python code base #20630
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review August 11, 2023 23:05
michael-s-molina
michael-s-molina approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 0879b92 into apache:master Aug 14, 2023
2 checks passed
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 18, 2023
@john-bodley @jinghua-qa
chore(dao): Remove redundant convenience methods (apache#24967)
c66a4c3 
(cherry picked from commit 0879b92)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@john-bodley
chore(dao): Remove redundant convenience methods (apache#24967)
d9ba000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @michael-s-molina @mistercrunch