chore: use os.getenv to simplify superset_config.py #25016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes a function in
superset_config.py
and replaces it by built-inos.getenv()
. Instead of raising an exception when the env variable is missing, they now have a default value. Their default values are the same as in.env
file (same values as in .env-non-dev)TESTING INSTRUCTIONS
Changes in
superset_config.py
only affect docker deployments, so in order to test this PR rundocker-compose up
and check variables values.ADDITIONAL INFORMATION