Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): Use docker buildx and Add ARM builds for dockerize and websocket #25377

Merged
merged 8 commits into from
Sep 25, 2023
Merged

feat(docker): Use docker buildx and Add ARM builds for dockerize and websocket #25377

merged 8 commits into from
Sep 25, 2023

Conversation

alekseyolg
Copy link
Contributor

@alekseyolg alekseyolg commented Sep 23, 2023 •
edited
Loading

SUMMARY

This adds an ARM build for dockerize and websocket. This is a naive implementation with buildx and QEMU.
Trying to rethink #24971

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@alekseyolg alekseyolg force-pushed the master branch 11 times, most recently from 1555b9b to 058451f Compare September 24, 2023 11:40
@alekseyolg alekseyolg force-pushed the master branch 11 times, most recently from 1843217 to a1287b2 Compare September 24, 2023 18:24
@alekseyolg alekseyolg changed the title feat(docker): Add ARM builds feat(docker): Use docker buildx and Add ARM builds for dockerize and websocket Sep 25, 2023
craig-rueda
craig-rueda approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@craig-rueda craig-rueda merged commit e1a91e2 into apache:master Sep 25, 2023
@adimyth
Copy link
Contributor

adimyth commented Dec 27, 2023

Will this create an ARM based image as well? Will it be available on docker hub?

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@alekseyolg
feat(docker): Use docker buildx and Add ARM builds for dockerize and …
259fe6d 
…websocket (apache#25377)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@EugeneTorap EugeneTorap mentioned this pull request Mar 22, 2024
Closed
11 tasks
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@alekseyolg
feat(docker): Use docker buildx and Add ARM builds for dockerize and …
0be9f32 
…websocket (apache#25377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alekseyolg @adimyth @craig-rueda @mistercrunch