Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqllab): ResultTable extension #25423

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat(sqllab): ResultTable extension #25423

merged 2 commits into from
Oct 17, 2023

Conversation

justinpark
Copy link
Member

SUMMARY

This commit create a new sqleditor extension sqleditor.extension.resultTable in order to extend the customization of the query result table.
This commit also reorganizes the JsonModal as a separate component and cell parser and renderer in the separate modules.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

eschutho
eschutho approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinpark justinpark force-pushed the feat--result-table-extension branch from afaca6e to e790380 Compare October 11, 2023 15:21
@justinpark justinpark merged commit deef3b0 into apache:master Oct 17, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@justinpark
feat(sqllab): ResultTable extension (apache#25423)
44fb4cd
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@justinpark @sfirke
feat(sqllab): ResultTable extension (apache#25423)
16a0ec3
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@justinpark
feat(sqllab): ResultTable extension (apache#25423)
1845ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@Antonio-RiveroMartnez Antonio-RiveroMartnez Awaiting requested review from Antonio-RiveroMartnez

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @eschutho @mistercrunch