Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Spelling #25454

Merged
merged 35 commits into from
Aug 20, 2024
Merged

chore(tests): Spelling #25454

merged 35 commits into from
Aug 20, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 28, 2023

SUMMARY

Some spelling fixes, a number of opinionated changes to make it easier to use a spell-checker (such as check-spelling) in the future.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jsoref
spelling: bootstrap
9005e22 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: error
a2f4a6b 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: example
bb923b1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: from-a
a707cf8 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: from
6769090 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: localhost
cefaea3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: mixed
af5e325 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: multiindex
4f16d62 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: preexisting
696182b 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: sqlite
5e38559 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: typeerror
7459b35 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: with
bc26a02 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
john-bodley
john-bodley reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsoref for the PR. I left a few suggestions.

tests/integration_tests/databases/api_tests.py Outdated Show resolved Hide resolved
tests/integration_tests/databases/api_tests.py Show resolved Hide resolved
tests/integration_tests/db_engine_specs/bigquery_tests.py Show resolved Hide resolved
tests/integration_tests/db_engine_specs/bigquery_tests.py Show resolved Hide resolved
tests/integration_tests/db_engine_specs/gsheets_tests.py Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_mssql.py
@@ -291,14 +291,14 @@ def test_extract_errors() -> None:
msg = dedent(
"""
DB-Lib error message 20009, severity 9:
Unable to connect: Adaptive Server is unavailable or does not exist (locahost)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous.

rusackas and others added 11 commits August 20, 2024 13:24
@rusackas
Merge branch 'master' into spelling-test
f13015c
@rusackas @john-bodley
Update tests/unit_tests/db_engine_specs/test_databricks.py
f53b710 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/unit_tests/db_engine_specs/test_databricks.py
674c266 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/unit_tests/db_engine_specs/test_databricks.py
9c5b277 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/unit_tests/db_engine_specs/test_databricks.py
2a3f46f 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/db_engine_specs/gsheets_tests.py
5d6ad12 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/db_engine_specs/bigquery_tests.py
0ffcd6f 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/db_engine_specs/postgres_tests.py
a8f3991 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/databases/api_tests.py
8569c8e 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/db_engine_specs/bigquery_tests.py
b8a407a 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/db_engine_specs/gsheets_tests.py
9d832dc 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas @john-bodley
Update tests/integration_tests/db_engine_specs/postgres_tests.py
cdf12b3 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (76d897e) to head (6f47641).
Report is 604 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #25454       +/-   ##
===========================================
+ Coverage   60.48%   83.64%   +23.15%     
===========================================
  Files        1931      528     -1403     
  Lines       76236    38148    -38088     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31910    -14204     
+ Misses      28017     6238    -21779     
+ Partials     2105        0     -2105
Flag Coverage Δ
hive 48.95% <ø> (-0.22%) ⬇️
javascript ?
mysql 76.64% <ø> (?)
postgres 76.74% <ø> (?)
presto 53.50% <ø> (-0.30%) ⬇️
python 83.64% <ø> (+20.15%) ⬆️
sqlite 76.22% <ø> (?)
unit 60.31% <ø> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rusackas
rusackas reviewed Aug 20, 2024
View reviewed changes
tests/integration_tests/databases/api_tests.py Outdated Show resolved Hide resolved
tests/integration_tests/db_engine_specs/bigquery_tests.py Outdated Show resolved Hide resolved
tests/integration_tests/db_engine_specs/gsheets_tests.py Outdated Show resolved Hide resolved
tests/integration_tests/db_engine_specs/postgres_tests.py Outdated Show resolved Hide resolved
tests/integration_tests/db_engine_specs/postgres_tests.py Outdated Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Outdated Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Outdated Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Outdated Show resolved Hide resolved
tests/unit_tests/db_engine_specs/test_databricks.py Outdated Show resolved Hide resolved
@rusackas rusackas merged commit 1818054 into apache:master Aug 20, 2024
37 checks passed
@rusackas
Copy link
Member

Thanks @jsoref for the help and explanation ;)

@jsoref jsoref deleted the spelling-test branch August 20, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley left review comments

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @rusackas @john-bodley