Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tags): don't allow users to create new tags from property dropdowns #25507

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 4, 2023

SUMMARY

Since we've added #24839 users now have a centralized places to create tags, now we are going to stop user from a being able to create tags from the dropdown for permissioning reasons.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-10-04.at.1.03.24.AM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
Copy link
Member

john-bodley commented Oct 4, 2023

@hughhhh could you provide more context in the PR description regarding the motivation of the change, and how one would go about creating new tags? Also would it be possible to add a unit test which will protect future regressions.

@hughhhh
Copy link
Member Author

hughhhh commented Oct 4, 2023

@hughhhh could you provide more context in the PR description regarding the motivation of the change, and how one would go about creating new tags? Also would it be possible to add a unit test which will protect future regressions.

Just updated the description with more details on the change, when it comes to testing what were you thinking on the component? honestly this is more a configuration vs. feature on the AsyncSelect imo

@hughhhh hughhhh merged commit 1fb2c62 into apache:master Oct 4, 2023
@hughhhh hughhhh deleted the tags-rm-create-dropdown branch October 4, 2023 19:51
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants