fix(tags): Polish + Better messaging for skipped tags with bad permissions #25578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
force-pushed
the
tags-error-msg-2
branch
from
db9590c to
fcde181
Compare
john-bodley
added
the
review:checkpoint
hughhhh
changed the title
lilykuang
approved these changes
Oct 10, 2023
john-bodley
removed
the
review:checkpoint
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 13, 2023
…sions (apache#25578) (cherry picked from commit 9074f72)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In branch fixed a few permissioning issue for Tags filters + updated toast to correspond or let the user know when certain entities couldn't be tagged (not the owner).
Messaging for Skipped Tags (not owner):
Fixed can read permissions on filters this only now show if users have the role (
can_read Tags):BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION