Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feature?): Bump scarf-js to 1.3.0 to get more telemetry data #25602

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Scarf 1.3.0 includes a fix to grab/aggregate the SHA of installations, so that we can know the relative age of installations that don't follow apache releases, know what security vulnerabilities they may be subject to, and know what proportion or our community uses Apache releases vs installs from GitHub.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

All should work as normal, but the Scarf dashboard should show a little more to Superset PMC members. Check the dashboard to make sure it works!

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #25602 (aa1c607) into master (f556ef5) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25602      +/-   ##
==========================================
+ Coverage   68.99%   69.01%   +0.01%     
==========================================
  Files        1930     1930              
  Lines       75463    75421      -42     
  Branches     8392     8383       -9     
==========================================
- Hits        52069    52052      -17     
+ Misses      21242    21221      -21     
+ Partials     2152     2148       -4     
Flag Coverage Δ
hive 53.69% <ø> (ø)
mysql 78.32% <ø> (ø)
postgres 78.42% <ø> (ø)
presto 53.64% <ø> (ø)
python 82.88% <ø> (ø)
sqlite 77.07% <ø> (ø)
unit 55.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...et-frontend/src/SqlLab/reducers/getInitialState.ts 86.66% <ø> (+2.66%) ⬆️
superset-frontend/src/SqlLab/reducers/sqlLab.js 53.08% <ø> (+3.66%) ⬆️
...d/src/explore/components/DatasourcePanel/index.tsx 65.82% <ø> (+1.62%) ⬆️
...rset-frontend/src/explore/components/SaveModal.tsx 39.31% <ø> (+0.47%) ⬆️
superset-frontend/src/hooks/useTabId.ts 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit ef1807c into master Oct 12, 2023
55 checks passed
@rusackas rusackas deleted the bump-scarf branch November 16, 2023 18:42
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants