Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Add option to deploy extra containers to init job #25783

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat(helm): Add option to deploy extra containers to init job #25783

merged 1 commit into from
Oct 31, 2023

Conversation

bluemalkin
Copy link
Contributor

@bluemalkin bluemalkin commented Oct 27, 2023 •
edited
Loading

SUMMARY

Adds extraContainers to init job pob.

This is required if for example connecting to an external database using the Cloud SQL Auth Proxy as a sidecar.

github-actions[bot]
github-actions bot reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

dpgaspar
dpgaspar reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not aware of how cloud-sql-auth-proxy works, but looking at the docs, shouldn't this go to deployment.yaml instead? since it's a sidecar?

@bluemalkin
Copy link
Contributor Author

not aware of how cloud-sql-auth-proxy works, but looking at the docs, shouldn't this go to deployment.yaml instead? since it's a sidecar?

@dpgaspar yes that's correct and the deployment.yaml has extraContainers however the init Job needs the sidecar too to connect to the db and bootstrap/upgrade it...

craig-rueda
craig-rueda approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@craig-rueda craig-rueda merged commit 0f01d9b into apache:master Oct 31, 2023
29 checks passed
@bluemalkin bluemalkin deleted the bluemalkin/init-extra-containers branch October 31, 2023 02:24
@bluemalkin bluemalkin mentioned this pull request Oct 31, 2023
Merged
@bluemalkin bluemalkin mentioned this pull request Nov 29, 2023
Merged
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
feat(helm): Add option to deploy extra containers to init job (apache…
063462a 
…#25783)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@sfirke
feat(helm): Add option to deploy extra containers to init job (apache…
e7359ae 
…#25783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@craig-rueda craig-rueda craig-rueda approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluemalkin @craig-rueda @dpgaspar @mistercrunch