fix: Revert "fix(sqllab): reinstate "Force trino client async execution" (#25680) #25896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#25680)" This reverts commit 4e94fc4.
|
@justinpark @sadpandajoe Please add any comments regarding your investigations that might help the author to fix the issue. |
|
@betodealmeida may have a better idea with the investigation |
|
See #25897 |
|
Verified #25897 fixes the trino multiple statement stuck issue. |
|
Closing in favor of #25897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This reverts commit 4e94fc4.
We have many users reporting queries being stuck for hours and never returning. Preset is also facing the same problem according to this comment from @sadpandajoe.
We're still not able to pinpoint the exact problem but we can confirm that reverting the original commit fixes the issue.
@villebro @giftig @sadpandajoe @john-bodley @justinpark
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION