Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update security policy and contributing #25917

Merged
merged 21 commits into from
Nov 22, 2023
Merged

docs: update security policy and contributing #25917

merged 21 commits into from
Nov 22, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Nov 8, 2023

SUMMARY

Updates repo security policy with new project specific email.

Proposes a new policy for the security team on the CONTRIBUTING.md document.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from sfirke November 8, 2023 18:31
@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Nov 8, 2023
john-bodley
john-bodley reviewed Nov 8, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@dpgaspar dpgaspar requested a review from john-bodley November 8, 2023 20:36
john-bodley
john-bodley reviewed Nov 8, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@dpgaspar dpgaspar requested a review from john-bodley November 9, 2023 14:51
sfirke
sfirke reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general clarifying & wordsmithing. I hope it's more of a help than it is a bother!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
dpgaspar and others added 7 commits November 10, 2023 11:49
@dpgaspar @sfirke
Update CONTRIBUTING.md
e44e798 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
c1da6d8 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
5482e02 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
269ef6c 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
a0b3c5d 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
6ea9531 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
fabce27 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
dpgaspar and others added 9 commits November 20, 2023 17:58
@dpgaspar @sfirke
Update CONTRIBUTING.md
6d1596e 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
33012d4 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar
address comments
7597db3
@dpgaspar @sfirke
Update CONTRIBUTING.md
36a04f4 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
36986de 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
1b7d82c 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
757a2d5 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
dbca916 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar @sfirke
Update CONTRIBUTING.md
ba3e6ef 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@dpgaspar dpgaspar requested a review from sfirke November 20, 2023 18:08
@dpgaspar
Copy link
Member Author

@sfirke thank you for all the suggestions!

sfirke
sfirke approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I flagged one formatting thing that I wasn't sure was intentional.

CONTRIBUTING.md Show resolved Hide resolved
@sfirke
Copy link
Member

sfirke commented Nov 21, 2023

I would merge if I could but we need a code reviewer to approve.

@dpgaspar dpgaspar merged commit 260d561 into apache:master Nov 22, 2023
26 checks passed
@dpgaspar dpgaspar deleted the fix/docs-security branch November 22, 2023 10:31
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Nov 30, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@dpgaspar @sfirke @josedev-union
docs: update security policy and contributing (apache#25917)
dbc89e6 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@dpgaspar @sfirke
docs: update security policy and contributing (apache#25917)
f98b02c 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke added a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@dpgaspar @sfirke
docs: update security policy and contributing (apache#25917)
b776f47 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@dpgaspar @sfirke
docs: update security policy and contributing (apache#25917)
1a0b733 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfirke sfirke sfirke approved these changes

@john-bodley john-bodley john-bodley approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpgaspar @sfirke @rusackas @john-bodley @mistercrunch