Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): Allow router navigation to explore #25941

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix(sqllab): Allow router navigation to explore #25941

merged 2 commits into from
Nov 14, 2023

Conversation

justinpark
Copy link
Member

SUMMARY

Follow up #25151, this commit updates the "Create Chart" action in SQL Lab result panel by router navigation. It also keeps the option to open in new window forcefully (/w window/cmd key click).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--spa-explore-link.mov

After:

after--spa-explore-link.mov

TESTING INSTRUCTIONS

Run a query in SQL Lab and then click "Create Chart"

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit f18fb24 into apache:master Nov 14, 2023
26 checks passed
@justinpark justinpark added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Dec 11, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@justinpark @josedev-union
fix(sqllab): Allow router navigation to explore (apache#25941)
294de99
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@justinpark
fix(sqllab): Allow router navigation to explore (apache#25941)
ca6a614
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@justinpark @sfirke
fix(sqllab): Allow router navigation to explore (apache#25941)
7186bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @michael-s-molina @mistercrunch