fix(dataset): Ensure DATETIME FORMAT is ISO 8601 compliant #26017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The dataset
DATETIME FORMAT
should be ISO 8601 compliant for lexicographical ordering purposes. This is mentioned throughout the code however the placeholder text for the dataset editor was%Y/%m/%d
which is non-compliant and likely lead people astray which resulted in #24113.#25510 reverts the validation logic, though this PR also ensures that the underlying placeholder text is changed to
%Y-%m-%d
per the ISO 8601 standard.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Updated unit tests.
ADDITIONAL INFORMATION
cc: @jfrag1