fix: set label on adhoc column should persist #26154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The component for defining columns has an unorthodox architecture:
When a user edits the label using the pencil in
<ColumnSelectPopoverTrigger />
, the<ColumnSelectPopover />
component is not aware of that change. If the users then clicks "SAVE" to use the adhoc column ("CUSTOM SQL") with the new label, the<ColumnSelectPopover />
won't do anything because it's not aware of any changes.This PR modifies
<ColumnSelectPopover />
so that if the user selects "CUSTOM SQL" and the label has been modified (via a new prophasCustomLabel
), then an adhoc column is defined in the component's state. This way, when "SAVE" is clicked, the label gets persisted correctly.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION