Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): undefined bounds for bubble chart #26243

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

villebro
Copy link
Member

SUMMARY

PR #26215 introduced a regression which caused Bubble Charts to fail to render.

AFTER

image

BEFORE

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: closes Bubble echart no longer loads #26242
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (136ad0e) 66.99% compared to head (73ebb30) 66.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26243   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files        1945     1945           
  Lines       75948    75948           
  Branches     8458     8460    +2     
=======================================
  Hits        50885    50885           
  Misses      22878    22878           
  Partials     2185     2185           
Flag Coverage Δ
javascript 56.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadpandajoe
Copy link
Member

@villebro can you spin up an ephemeral?

@villebro
Copy link
Member Author

/testenv up

Copy link
Contributor

@villebro Ephemeral environment spinning up at http://35.164.94.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@villebro
Copy link
Member Author

@sadpandajoe here's a bubble chart created from scratch: http://35.164.94.117:8080/superset/explore/p/BzZjq7RQNnK/

image

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadpandajoe
Copy link
Member

LGTM too. Tested out on new bubble chart along with playing around with the truncate feature on there.

@villebro villebro merged commit 5df544b into apache:master Dec 12, 2023
30 checks passed
@villebro villebro deleted the villebro/fix-bubble branch December 12, 2023 17:22
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Dec 12, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 18, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bubble echart no longer loads
4 participants