Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared components): Migrate enzyme to RTL #26258

Conversation

justinpark
Copy link
Member

SUMMARY

This commit migrates enzyme testing codes by react testing-library for src/components

TESTING INSTRUCTIONS

npm run test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ac2892) 69.18% compared to head (0ebd057) 69.20%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26258      +/-   ##
==========================================
+ Coverage   69.18%   69.20%   +0.02%     
==========================================
  Files        1945     1945              
  Lines       75948    75948              
  Branches     8458     8460       +2     
==========================================
+ Hits        52544    52561      +17     
+ Misses      21219    21209      -10     
+ Partials     2185     2178       -7     
Flag Coverage Δ
javascript 56.56% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinpark justinpark force-pushed the chore--migrate-enzyme-test-codes-for-common-components branch from 0ebd057 to a8b50da Compare August 15, 2024 01:42
@justinpark
Copy link
Member Author

@michael-s-molina @rtexelm could you help this PR review? This commit has been open for a long time, and I recently resolved the rebase conflict as well.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had my friend Claude help review it, and all seems well.

@justinpark justinpark merged commit 1a1548d into apache:master Aug 21, 2024
34 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 6, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants