Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot expand initially hidden SQL Lab tab #26279

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug that prevented SQL Lab tabs to be expanded when they were initially hidden.

Fixes #26248

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-12-14.at.14.04.09.mov
Screen.Recording.2023-12-14.at.14.03.05.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (429e2a3) 66.99% compared to head (775337b) 66.99%.

Files Patch % Lines
...frontend/src/SqlLab/components/SqlEditor/index.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26279      +/-   ##
==========================================
- Coverage   66.99%   66.99%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75949    75949              
  Branches     8460     8460              
==========================================
- Hits        50885    50884       -1     
  Misses      22879    22879              
- Partials     2185     2186       +1     
Flag Coverage Δ
javascript 56.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina merged commit aa3c3c5 into apache:master Dec 14, 2023
31 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 15, 2023
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Dec 15, 2023
michael-s-molina added a commit that referenced this pull request Dec 18, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sqlLab] left side tool bar does not working after browser refreshing
4 participants