Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid references in the basic template #26302

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 18, 2023

SUMMARY

Fixes invalid references in superset/templates/superset/basic.html which were generating the following 404 errors:

GET http://localhost:9000/static/appbuilder/datepicker/ net::ERR_ABORTED 404

GET http://localhost:9000/static/appbuilder/datepicker/bootstrap-datepicker.css net::ERR_ABORTED 404
        
GET http://localhost:9000/static/appbuilder/select2/select2.css net::ERR_ABORTED 404
        
GET http://localhost:9000/static/appbuilder/select2/select2-bootstrap-theme.css net::ERR_ABORTED 404

These references were introduced by #24390.

The new references are:

GET http://localhost:9000/static/appbuilder/css/bootstrap-datepicker/bootstrap-datepicker3.min.css

GET http://localhost:9000/static/appbuilder/css/select2/select2.min.css

GET http://localhost:9000/static/appbuilder/css/select2/select2-bootstrap.min.css

Fixes #26267

Fixes #26072

TESTING INSTRUCTIONS

Follow the instructions in the original issue.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Comment on lines -51 to -54
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/datepicker/bootstrap-datepicker.css">
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/datepicker/bootstrap-datepicker.css">
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/select2/select2.css">
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/select2/select2-bootstrap-theme.css">
Copy link
Member Author

@michael-s-molina michael-s-molina Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change is fixing these 4 lines. The rest is just HTML formatting.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (429e2a3) 66.99% compared to head (6ea1144) 66.99%.
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26302      +/-   ##
==========================================
- Coverage   66.99%   66.99%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75949    75946       -3     
  Branches     8460     8460              
==========================================
- Hits        50885    50878       -7     
- Misses      22879    22883       +4     
  Partials     2185     2185              
Flag Coverage Δ
mysql 78.07% <ø> (+0.01%) ⬆️
postgres 78.17% <ø> (-0.02%) ⬇️
python 78.31% <ø> (-0.02%) ⬇️
sqlite 76.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina requested a review from a team December 29, 2023 14:02
@michael-s-molina michael-s-molina changed the title fix: Clean up invalid references in the basic template fix: Invalid references in the basic template Jan 3, 2024
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 3, 2024
@michael-s-molina michael-s-molina merged commit 9432bd8 into apache:master Jan 3, 2024
37 checks passed
michael-s-molina added a commit that referenced this pull request Jan 3, 2024
michael-s-molina added a commit that referenced this pull request Jan 3, 2024
sivasathyaseeelan pushed a commit to sivasathyaseeelan/superset that referenced this pull request Jan 3, 2024
michael-s-molina added a commit that referenced this pull request Jan 4, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
3 participants