-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Invalid references in the basic template #26302
fix: Invalid references in the basic template #26302
Conversation
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/datepicker/bootstrap-datepicker.css"> | ||
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/datepicker/bootstrap-datepicker.css"> | ||
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/select2/select2.css"> | ||
<link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/select2/select2-bootstrap-theme.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual change is fixing these 4 lines. The rest is just HTML formatting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26302 +/- ##
==========================================
- Coverage 66.99% 66.99% -0.01%
==========================================
Files 1945 1945
Lines 75949 75946 -3
Branches 8460 8460
==========================================
- Hits 50885 50878 -7
- Misses 22879 22883 +4
Partials 2185 2185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 9432bd8)
(cherry picked from commit 9432bd8)
(cherry picked from commit 9432bd8)
(cherry picked from commit 9432bd8)
SUMMARY
Fixes invalid references in
superset/templates/superset/basic.html
which were generating the following 404 errors:These references were introduced by #24390.
The new references are:
Fixes #26267
Fixes #26072
TESTING INSTRUCTIONS
Follow the instructions in the original issue.
ADDITIONAL INFORMATION