-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): narrow empty drop area #26313
fix(dashboard): narrow empty drop area #26313
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26313 +/- ##
=======================================
Coverage 69.18% 69.19%
=======================================
Files 1946 1946
Lines 75969 75982 +13
Branches 8469 8468 -1
=======================================
+ Hits 52561 52572 +11
- Misses 21222 21223 +1
- Partials 2186 2187 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://34.221.235.129:8080. Credentials are |
@justinpark I noticed that for some reason, I lost the ability to drag items to the dashboard. Sometimes if I refresh the dashboard, I'm able to drag them but after dropping some charts, the bug reappears. I was not able to reproduce the bug on master. Screen.Recording.2023-12-20.at.09.31.56.mov |
5f120c9
to
1ed42ac
Compare
@michael-s-molina thanks for the testing. I found the some css rule made the side effects. I just updated the hotfix for this bug. |
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://52.33.238.156:8080. Credentials are |
ping @michael-s-molina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
This is so so so cool! Thank you so much for this improvement. |
(cherry picked from commit 300ddae)
(cherry picked from commit 300ddae)
(cherry picked from commit 300ddae)
SUMMARY
We've noticed that users are having difficulty adding an element into the tab content area because of its restricted drop zone. This commit expands the drop area for empty content to resolve the problem.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--droparea.mov
After:
after--droparea.mov
TESTING INSTRUCTIONS
Edit Dashboard and drag and drop to the new tab content
ADDITIONAL INFORMATION