fix(tagging): adding tags containing a “:” to dashboards #26324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26324 +/- ##
==========================================
- Coverage 69.18% 69.18% -0.01%
==========================================
Files 1945 1945
Lines 75971 75962 -9
Branches 8467 8467
==========================================
- Hits 52559 52551 -8
+ Misses 21225 21224 -1
Partials 2187 2187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hughhhh
reviewed
Dec 22, 2023
| @@ -19,6 +19,7 @@ | |||
| import enum | |||
| from typing import TYPE_CHECKING | |||
|
|
|||
| from flask import escape | |||
hughhhh
reviewed
Dec 22, 2023
| ) | ||
|
|
||
| # test that a tag can be added if it has ',' in it | ||
| TagDAO.create_custom_tagged_objects( |
There was a problem hiding this comment.
nit: can we add few more test with different symbols? like ., -, /, etc.
hughhhh
approved these changes
Dec 22, 2023
|
🏷️ preset:2023.51 |
|
will add more tests in a new pr |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Dec 22, 2023
will add more tests in a separated PR (cherry picked from commit 3391e29)
michael-s-molina
added
the
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 27, 2023
will add more tests in a separated PR (cherry picked from commit 3391e29)
|
Looks like this will show private/protected tags that aren't normally shown to users like |
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Dec 28, 2023
…che#26324)" This reverts commit 3391e29.
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Jan 8, 2024
…che#26324)" This reverts commit 3391e29.
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Jan 13, 2024
…che#26324)" This reverts commit 3391e29.
9 tasks
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
will add more tests in a separated PR (cherry picked from commit 3391e29)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
will add more tests in a separated PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION