-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix config webdriver snippet in install on K8s #26371
docs: fix config webdriver snippet in install on K8s #26371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the issue & fix! This is not my most familiar area so hopefully someone else will review. From reading a comparison it sounds like |
Hi @sfirke. Thanks for taking time to review this PR. Regarding the use of
Here are the full logs during the pod initialisation when configured with the changes I'm suggesting (sorry for the size):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for the explanation! And for the fix. Superset's k8s deployment is in a gray area, it has many users but is not "officially supported" yet due to lack of developer maintenance and oversight from the community. So your contribution is especially appreciated! |
My pleasure. Will try to help as much as I can. Btw, happy holidays! 🎉 |
You too! 😁 |
SUMMARY
The current example of installing
webdriver
on worker nodes when installing Superset on Kubernetes causes the configuration to fail. This PR is fix the issue.TESTING INSTRUCTIONS
values.yaml
file as per the new snippet included in this PRkubectl logs -f superset-worker-<xxx>
ADDITIONAL INFORMATION
Fixes #26370