-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(embedded): Hide dashboard fullscreen option for embedded context #26412
fix(embedded): Hide dashboard fullscreen option for embedded context #26412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26412 +/- ##
=======================================
Coverage 69.15% 69.15%
=======================================
Files 1947 1947
Lines 76010 76011 +1
Branches 8481 8481
=======================================
+ Hits 52565 52569 +4
+ Misses 21264 21261 -3
Partials 2181 2181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hey @kgabryje @michael-s-molina @geido would appreciate your thoughts here 🙏 |
Hi @betodealmeida ! Do you know in which version this issue will be deployed ? |
@aehanno As any fix that is applicable to a specific version, it will be available in the next patch for that version. In this case, 3.0.4 (because 3.0.3 is already being voted) and 3.1.1 (because 3.1.0 is already being voted). Check the Patch releases section of our Release Process. |
thanks for the clarification, @michael-s-molina! Also let me know if you have any concerns with this approach. |
SUMMARY
When a dashboard is loaded in embedded mode, the layout is already matching "fullscreen mode" (the top navigation bar is not visible), so there's no reason to show this option in embedded mode. Also, the dashboard is stuck loading when clicking on this option in embedded mode.
Fixes #22537
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
EMBEDDED_SUPERSET