Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embedded): Hide dashboard fullscreen option for embedded context #26412

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

When a dashboard is loaded in embedded mode, the layout is already matching "fullscreen mode" (the top navigation bar is not visible), so there's no reason to show this option in embedded mode. Also, the dashboard is stuck loading when clicking on this option in embedded mode.

Fixes #22537

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Make sure you have Embedded enabled and properly configured in your environment.
  2. Access a dashboard in embedded mode.
  3. Access the dashboard menu, and confirm that Enter fullscreen option is not visible.

ADDITIONAL INFORMATION

  • Has associated issue: Error fullscreen embedded dashboard #22537
  • Required feature flags: EMBEDDED_SUPERSET
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a7d76c) 69.15% compared to head (6cd4594) 69.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26412   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files        1947     1947           
  Lines       76010    76011    +1     
  Branches     8481     8481           
=======================================
+ Hits        52565    52569    +4     
+ Misses      21264    21261    -3     
  Partials     2181     2181           
Flag Coverage Δ
javascript 56.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vitor-Avila
Copy link
Contributor Author

hey @kgabryje @michael-s-molina @geido would appreciate your thoughts here 🙏

@betodealmeida betodealmeida merged commit 494068b into apache:master Jan 11, 2024
30 checks passed
@aehanno
Copy link
Contributor

aehanno commented Jan 12, 2024

Hi @betodealmeida ! Do you know in which version this issue will be deployed ?

@michael-s-molina
Copy link
Member

michael-s-molina commented Jan 12, 2024

Hi @betodealmeida ! Do you know in which version this issue will be deployed ?

@aehanno As any fix that is applicable to a specific version, it will be available in the next patch for that version. In this case, 3.0.4 (because 3.0.3 is already being voted) and 3.1.1 (because 3.1.0 is already being voted). Check the Patch releases section of our Release Process.

@Vitor-Avila
Copy link
Contributor Author

thanks for the clarification, @michael-s-molina! Also let me know if you have any concerns with this approach.

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 17, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 18, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 18, 2024
@mistercrunch mistercrunch added 🍒 3.0.4 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.4 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fullscreen embedded dashboard
5 participants