Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translation): correct translation errors for Chinese(zh) #26645

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Waterkin
Copy link
Contributor

@Waterkin Waterkin commented Jan 17, 2024

BEFORE

#: superset-frontend/src/dashboard/components/gridComponents/Tab.jsx:210
#, fuzzy
msgid "edit mode"
msgstr "光模式"

#: superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx:184
msgid "heatmap: values are normalized across the entire heatmap"
msgstr ""

#: superset-frontend/packages/superset-ui-core/src/validator/legacyValidateInteger.ts:31
#: superset-frontend/packages/superset-ui-core/src/validator/validateInteger.ts:32
msgid "is expected to be an integer"
msgstr "应该为为整数"

#: superset-frontend/src/explore/controlPanels/sections.tsx:255
#, fuzzy
msgid "mean"
msgstr "主域"

#: superset-frontend/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx:376
#: superset-frontend/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx:258
#: superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Hex/controlPanel.ts:78
#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx:530
#: superset-frontend/src/explore/controlPanels/sections.tsx:254
msgid "median"
msgstr ""

#: superset-frontend/src/filters/components/Range/buildQuery.ts:58
#, fuzzy
msgid "min"
msgstr "在"

AFTER

#: superset-frontend/src/dashboard/components/gridComponents/Tab.jsx:210
#, fuzzy
msgid "edit mode"
msgstr "编辑模式"

#: superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx:184
msgid "heatmap: values are normalized across the entire heatmap"
msgstr "热力图:其中所有数值都经过了归一化"

#: superset-frontend/packages/superset-ui-core/src/validator/legacyValidateInteger.ts:31
#: superset-frontend/packages/superset-ui-core/src/validator/validateInteger.ts:32
msgid "is expected to be an integer"
msgstr "应该为整数"

#: superset-frontend/src/explore/controlPanels/sections.tsx:255
#, fuzzy
msgid "mean"
msgstr "平均值"

#: superset-frontend/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx:376
#: superset-frontend/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx:258
#: superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Hex/controlPanel.ts:78
#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx:530
#: superset-frontend/src/explore/controlPanels/sections.tsx:254
msgid "median"
msgstr "中位数"

#: superset-frontend/src/filters/components/Range/buildQuery.ts:58
#, fuzzy
msgid "min"
msgstr "分钟"

Signed-off-by: Waterkin <1055905911@qq.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley self-requested a review January 17, 2024 17:54
@john-bodley
Copy link
Member

Thanks @Waterkin for improving the translations.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e19f59) 69.06% compared to head (0b07686) 69.06%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26645   +/-   ##
=======================================
  Coverage   69.06%   69.06%           
=======================================
  Files        1930     1930           
  Lines       75309    75309           
  Branches     8429     8429           
=======================================
+ Hits        52013    52014    +1     
+ Misses      21149    21148    -1     
  Partials     2147     2147           
Flag Coverage Δ
hive 53.59% <ø> (ø)
mysql 77.86% <ø> (-0.03%) ⬇️
postgres 77.99% <ø> (ø)
presto 53.54% <ø> (ø)
python 82.75% <ø> (+<0.01%) ⬆️
sqlite 77.57% <ø> (ø)
unit 55.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked things in google Translate, and we're looking good! Thanks for these improvements!

@rusackas rusackas merged commit 8539dfd into apache:master Jan 18, 2024
36 checks passed
Muhammed-baban pushed a commit to intellica-tech/reporting-tool that referenced this pull request Jan 19, 2024
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 22, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 25, 2024
Signed-off-by: Waterkin <1055905911@qq.com>
(cherry picked from commit 8539dfd)
michael-s-molina pushed a commit that referenced this pull request Jan 25, 2024
Signed-off-by: Waterkin <1055905911@qq.com>
(cherry picked from commit 8539dfd)
@mistercrunch mistercrunch added 🍒 3.0.4 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.4 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants