-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove database ID dependency for SSH Tunnel creation #26989
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26989 +/- ##
==========================================
+ Coverage 67.31% 69.66% +2.34%
==========================================
Files 1895 1895
Lines 74202 74224 +22
Branches 8219 8219
==========================================
+ Hits 49949 51705 +1756
+ Misses 22204 20470 -1734
Partials 2049 2049
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good. Thanks @geido. My only question is around whether we need the add param on the db dao.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just left a few comments.
SUMMARY
This PR removes the requirement to pass a database ID to the SSHTunnel command. It also removes the premature call of SQLAlchemy ORM listeners, such as
after_insert
, caused by the use offlush
andbegin_nested
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION