Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker CI job doesn't trigger on master #27261

Merged
merged 3 commits into from
Feb 27, 2024
Merged

fix: docker CI job doesn't trigger on master #27261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328ece3
fix: docker CI job doesn't trigger on master
mistercrunch Feb 27, 2024
7655d9c
remove no-op
mistercrunch Feb 27, 2024
59b92c9
debugging fromJSON
mistercrunch Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,24 @@ concurrency:
cancel-in-progress: true

jobs:
setup_matrix:
runs-on: ubuntu-latest
outputs:
matrix_config: ${{ steps.set_matrix.outputs.matrix_config }}
steps:
- id: set_matrix
run: |
MATRIX_CONFIG=$(if [ "${{ github.event_name }}" == "pull_request" ]; then echo '["ci"]'; else echo '["dev", "lean", "py310", "websocket", "dockerize"]'; fi)
echo "matrix_config=${MATRIX_CONFIG}" >> $GITHUB_OUTPUT
echo $GITHUB_OUTPUT

docker-build:
name: docker-build
needs: setup_matrix
runs-on: ubuntu-latest
strategy:
matrix:
build_preset: |
${{ fromJson(github.event_name == 'pull_request' ? '["ci"]' : '["dev", "lean", "py310", "websocket", "dockerize"]') }}
build_preset: ${{fromJson(needs.setup_matrix.outputs.matrix_config)}}
fail-fast: false
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
Expand Down
17 changes: 0 additions & 17 deletions .github/workflows/no-op.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,3 @@ jobs:
run: |
echo "This is a no-op step for python-lint to ensure a successful status."
exit 0
# section to be deleted after master merge
docker-build:
strategy:
matrix:
build_preset: ["dev", "lean", "py310", "websocket", "dockerize"]
platform: ["linux/amd64", "linux/arm64"]
exclude:
- build_preset: "dev"
platform: "linux/arm64"
- build_preset: "lean"
platform: "linux/arm64"
runs-on: ubuntu-latest
steps:
- name: No-op for docker
run: |
echo "No-op to get rid of the docker-build checks reqs in .asf.yml"
exit 0
Loading