Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#27117 removed the following deprecated endpoint:
Which was registered in Superset's initialization:
superset init
uses the registered views to dynamically generate the permissions, in that case,can_sqllab
was generated from that entry and it does not exist anymore in a fresh installation of Superset. Searching for can_sqllab we can still find many references to it in the codebase, including the menu item that is missing. This PR adds that permission back using custom permissions.I also did a diff between 3.1 and 4.0 and found that the following permissions were removed:
The only permission that is still referenced in the codebase is
can_sqllab
.Fixes #27310
TESTING INSTRUCTIONS
Check that the
SQL query
option appears in the global + menu.ADDITIONAL INFORMATION