Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): fix off-by-one error in how rolling window's min_periods truncates dataframe #27388

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix(utils): fix off-by-one error in how rolling window's min_periods truncates dataframe #27388

merged 3 commits into from
Mar 21, 2024

Commits on Mar 4, 2024

  1. don't truncate Nth period for min_periods = N

    @sfirke
    sfirke committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b5662c8 View commit details
    Browse the repository at this point in the history

  2. rewrite test of min_periods

    @sfirke
    sfirke committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    4aa8d60 View commit details
    Browse the repository at this point in the history

  3. fix linting

    @sfirke
    sfirke committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a30b7ce View commit details
    Browse the repository at this point in the history