Escape colon in SQL properly #2777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
fix_escaping
branch
from
6a1db89
to
2b9d2b7
Compare
ascott
reviewed
May 18, 2017
| @@ -97,6 +97,8 @@ def process_template(self, sql, **kwargs): | |||
| >>> process_template(sql) | |||
| "SELECT '2017-01-01T00:00:00'" | |||
| """ | |||
| # Escaping colon | |||
| sql = sql.replace(':', '\:') | |||
There was a problem hiding this comment.
what if a user escapes the colon themselves? would '\:' then equal '\\:'? should we add a test for this case?
There was a problem hiding this comment.
Seems like the escaping is only required for some database engines as well. The specs being loose and the sqlalchemy dialects being of varying quality it makes this really hard on our end...
|
Superseeded by #3186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.