fix(sql_parse): Provide more lenient logic when extracting latest[_sub]_partition #28152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Apr 19, 2024
| {Table(table="bar", schema="foo")}, | ||
| ), | ||
| ( | ||
| "SELECT * FROM foo.baz WHERE quux = '{{{{ {engine}.{macro} }}}}'", |
There was a problem hiding this comment.
This example no longer exists. It's a trivial extension from the previous logic, but was making the nested parametrization challenging.
john-bodley
commented
Apr 19, 2024
| ] | ||
| # Try to extract the table referenced in the macro. | ||
| try: | ||
| tables.add( |
There was a problem hiding this comment.
Same logic as before, just nested within a try/except block.
michael-s-molina
approved these changes
Apr 23, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
michael-s-molina
added
v4.0
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 3.1.3
🍒 4.0.1
🍒 4.0.2
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a follow up to #28117, which sadly wasn't suffice when variables as opposed to constants were being used with the
format()Jinja macro.Sadly the
as_const()method has only been implemented for a subset of node types and given that the plethora of logic which one could define is vast it's likely best to just acknowledge there are times when we wont be able to accurately extract the table referenced by thelatest[_sub]_partitionJinja macro.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION