Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(intro): embed overview video into Intro document #28163

Merged

Conversation

hainenber
Copy link
Contributor

docs(intro): embed overview video into Intro document

SUMMARY

Embed existing overview video about Superset into Intro document intro.mdx to help new users having faster understanding visually.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

Closes #28162

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Apr 20, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley requested a review from rusackas April 22, 2024 17:27
@rusackas
Copy link
Member

We might have to move the hosted, but I like the idea!

@hainenber
Copy link
Contributor Author

We might have to move the hosted, but I like the idea!

While I also share the sentiment of moving the video to some more reliable host, I think we can rely on it for the time being.

@hainenber
Copy link
Contributor Author

Hello folks, is there anything not desired yet for merging in this PR? :D

@rusackas rusackas merged commit 2e9cc65 into apache:master Apr 30, 2024
30 of 31 checks passed
@rusackas
Copy link
Member

Nothing that needs to actually block the PR, in my book!

jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overview video about Superset should be embed in Intro documentation
3 participants