chore: document upper bound for python lib 'holidays' >= 0.26 #28747
Conversation
There was a problem hiding this comment.
@michael-s-molina or @villebro do either of you know why we previously had an upper bound of 0.26 here?
pyproject.toml
Outdated
| @@ -57,7 +57,7 @@ dependencies = [ | |||
| "geopy", | |||
| "gunicorn>=22.0.0; sys_platform != 'win32'", | |||
| "hashids>=1.3.1, <2", | |||
| "holidays>=0.25, <0.26", | |||
| "holidays>=0.25", | |||
There was a problem hiding this comment.
Should we bump the lower bound and also place an upper bound of 1.0.0 as well?
|
@mistercrunch it would be good to determine if the issue in #25017 has been resolved. |
|
@john-bodley great catch! I totally would have missed that. I think we really need to add comments for all real upper bounds in pyroject.toml, including if it's just "based on semantic versioning and/or stress levels around this specific dependency". I'm planning on implementing something like or something like |
I simply removed the upper bound for the holidays lib and ran `pip-compile-multi -P holidays`. Note that `pip-compile-multi` isn't as' deterministic as we'd like for it to be, but things should be fine as "# vias" are just informational here.
mistercrunch
force-pushed
the
holidays
branch
from
462bf2d
to
236a217
Compare
mistercrunch
changed the title
|
@rusackas closing/cleaning some old PRs if you don't mind stamping this |
Change of plans, adding a note documenting the upper bound
I simply removed the upper bound for the holidays lib and ranpip-compile-multi -P holidays. Note thatpip-compile-multiisn't as' deterministic as we'd like for it to be, but things should be fine as "# vias" are just informational here.For the record: https://github.com/vacanza/python-holidays/blob/dev/CHANGES