-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): Set priorityClassName to pods (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) #29091
Conversation
…Flower, celeryBeatWorker, celeryBeatWebsocket, jobs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please bump the chart version and re-build the chart README? |
@craig-rueda Yes, I can. But isnt it done automatically after the merge? Or should I trigger manually a workflow? Could you just elaborate a little about the process please? |
Ok, I see it needs to be released locally if I am not wrong, and send as a separate PR like this, is that right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I've also needed this, so I assume this is useful to the general public, too). Not sure what the unrelated lint issue is, will try to repro locally.
@villebro Thank you for review. I wrote yesterday in slack channel. Maybe you missed it. |
@sabyrzhan oh, that skip on CI shouldn't have happened IMO (probably warrants looking into separately from this, though) 🙁 Do you think you'll be able to fix it as a bycatch here? I'm assuming it should be simple to fix. If not I can take a stab at it. |
@villebro sure, not a problem. Will start fixing right now and push it. |
Thanks @sabyrzhan ! |
@villebro Pushed the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restamping - big thanks for fixing this unrelated error!
…yBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) (#29091)
@villebro Any estimates when the next release of the helm chart is going to be? I see the last one was on May. |
@sabyrzhan the helm chart should be automatically released by CI. Let me take a look to see why this is not the case.. |
@villebro It seems as if this feature is still not available in the latest chart. Can you have another look? |
…yBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) (apache#29091)
I'm now investigating why the GHA workflow isn't triggering. |
@villebro Thanks for the fix. Happy about the working |
SUMMARY
Add ability to assign custom
priorityClassName
to pods. Each workload (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) has ability to assign custompriorityClassName
TESTING INSTRUCTIONS
Specify custom
priorityClassName
to one of the deployments (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) to assign to its podsADDITIONAL INFORMATION