refactor(sqllab): nonblocking switch query editor #29108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up #24539
This commit modifies the
setActiveQueryEditor
function to asynchronously handle the process of switching active a queryEditor in localStorage in the same way as in non-persistent mode and periodically post active state to persistence via AutoSync'supdateCurrentSqlEditor
.This commit made the following changes:
switchQueryEditor
, and instead changed it to fetchQueryEditor to clearly fetch the persistent queryEditor record from the apisetActiveQueryEditor
has been modified to always apply to localStorage in the same way as in non-persistence modeupdateCurrentSqlEditor
periodically and then setlastUpdatedActiveTab
on successBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In a state of network delay
Before:
before--nonblocking-switch.mov
After:
after--nonblocking-switch.mov
TESTING INSTRUCTIONS
set SQLLAB_BACKEND_PERSISTENCE on
go to sqllab and then switch each tab quickly
ADDITIONAL INFORMATION