Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI failture due to Default React import #29110

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: CI failture due to Default React import #29110

merged 1 commit into from
Jun 6, 2024

Conversation

justinpark
Copy link
Member

SUMMARY

This commit fixes the following CI failure due to the #28637 regression.

/home/runner/work/superset/superset/superset-frontend/src/explore/components/controls/DateFilterControl/components/CurrentCalendarFrame.tsx
Error:   19:8  error  Default React import is not required due to automatic JSX runtime in React 16.4  no-restricted-syntax

/home/runner/work/superset/superset/superset-frontend/src/explore/components/controls/DateFilterControl/tests/CurrentCalendarFrame.test.tsx
Error:   19:8  error  Default React import is not required due to automatic JSX runtime in React 16.4  no-restricted-syntax

✖ 2 problems (2 errors, 0 warnings)

Error: Process completed with exit code 1.

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark requested a review from rusackas June 6, 2024 22:42
@dosubot dosubot bot added the explore:control Related to the controls panel of Explore label Jun 6, 2024
@justinpark
Copy link
Member Author

cc @pranav1699

@justinpark justinpark changed the title hotfix: CI failture due to Default React import fix: CI failture due to Default React import Jun 6, 2024
@justinpark justinpark merged commit fc9bc17 into apache:master Jun 6, 2024
37 of 39 checks passed
@justinpark justinpark deleted the hotfix--no-restricted-syntax branch June 6, 2024 23:14
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@justinpark @eschutho
fix: CI failture due to Default React import (#29110)
1534965
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@justinpark
fix: CI failture due to Default React import (apache#29110)
f412f7a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @rusackas @mistercrunch